Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): expand invalid state upon glossary term add #18968

Merged
merged 7 commits into from
Dec 16, 2024
Merged

fix(ui): expand invalid state upon glossary term add #18968

merged 7 commits into from
Dec 16, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Dec 9, 2024 •
edited
Loading

invalid expand state for glossary term update

Describe your changes:

Fixes:

  • Expand / collapse icon got vanish upon editing term in the Term table
  • Expand state goes missing on adding new term to other glossary term

Issue

Screen.Recording.2024-12-09.at.2.57.14.PM.mov

Fix

Screen.Recording.2024-12-09.at.2.58.16.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani
fix(ui): expand invalid state upon glossary term add
226d959 
invalid expand state for glossary term update
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Dec 9, 2024
karanh37
karanh37 previously approved these changes Dec 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.87% (40087/62763) 40.4% (16054/39736) 43.07% (4808/11163)

karanh37
karanh37 previously approved these changes Dec 16, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 254fce4 into main Dec 16, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the fix-glossary-term-listing branch December 16, 2024 16:38
Ashish8689 pushed a commit that referenced this pull request Dec 19, 2024
@chirag-madlani @Ashish8689
fix(ui): expand invalid state upon glossary term add (#18968)
1f59cec 
* fix(ui): expand invalid state upon glossary term add
invalid expand state for glossary term update

* fix tests

* update glossary store upon changes in tree

* fix tests

(cherry picked from commit 254fce4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chirag-madlani @karanh37 @Sachin-chaurasiya @ShaileshParmar11