Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page #18993

shrushti2000 · 2024-12-10T16:00:09Z

Added Announcements listing functionality in the Activity Feed Tab along with CRUD functionality.
Added Announcements Tab in Service page which has Announcements listing with CRUD functionality.
Redirect users to Announcements tab in Service page or subtab in Activity Feed respectively when clicked on the active announcement card.
Removed the Announcements Drawer.
Removed Announcement option from Manage Button

Note: The implementation for the count of announcements is currently not included in this PR. This will be added once the necessary backend changes are completed and available.

Announcements Listing in Activity Feed

Screen.Recording.2024-12-16.at.8.31.49.PM.2.3.1.mov

Announcements Listing in Service Page

Screen.Recording.2024-12-16.at.8.33.13.PM.1.1.1.mov

Update Manage Button

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

…e page

github-actions · 2024-12-10T16:00:39Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions · 2024-12-11T14:26:30Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions · 2024-12-12T14:14:53Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions · 2024-12-13T11:31:24Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

chirag-madlani · 2024-12-18T16:51:59Z

openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts

-  await expect(page.getByTestId('announcement-error')).toContainText(
-    'No Announcements, Click on add announcement to add one.'
-  );
-
-  await page.getByTestId('add-announcement').click();


We still have this for no announcement right? inside announcement tab?

yes, we have, added this check in the test

chirag-madlani · 2024-12-18T16:53:40Z

openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts

+  if (isForActivityFeedTab) {
+    const activityFeedText = (await page
+      .getByText('Activity Feeds & Tasks')
+      .isVisible())
+      ? 'Activity Feeds & Tasks'
+      : 'Activity Feeds';


Can we try it with selector instead of text? both should have same role-id I guess

done, used role id as the selector.

chirag-madlani · 2024-12-18T16:59:28Z

openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts

-  // Edit the reply message
-  await page.hover('[data-testid="replies"] > [data-testid="main-message"]');
-  await page.waitForSelector('.ant-popover', { state: 'visible' });
-  await page.click('[data-testid="edit-message"]');
-
-  await page.fill(
-    '[data-testid="editor-wrapper"] .ql-editor',
-    'Reply message edited'
-  );
-
-  await page.click('[data-testid="save-button"]');
-
-  await expect(
-    page.locator('[data-testid="replies"] [data-testid="viewer-container"]')
-  ).toHaveText('Reply message edited');


We are missing this test

done,Added this test

chirag-madlani · 2024-12-18T17:00:11Z

openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts

+  if (isForActivityFeedTab) {
+    const activityFeedText = (await page
+      .getByText('Activity Feeds & Tasks')
+      .isVisible())
+      ? 'Activity Feeds & Tasks'
+      : 'Activity Feeds';


chirag-madlani · 2024-12-18T17:04:05Z

.../src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCardV2/ActivityFeedCardV2.tsx

+    const callback = () => {
+      return;
+    };
+    await updateThreadData(threadId, postId, isThread, data, callback);


Suggested change

await updateThreadData(threadId, postId, isThread, data, callback);

await updateThreadData(threadId, postId, isThread, data, noop);

can use noop

chirag-madlani · 2024-12-18T17:17:27Z

.../main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/ActivityFeedTab.component.tsx

+                    <div
+                      className="d-flex justify-between"
+                      data-testid="announcement-sub-tab">
+                      <Space align="center" size="small">
+                        <AnnouncementsIcon
+                          style={COMMON_ICON_STYLES}
+                          {...ICON_DIMENSION}
+                        />
+                        <span>{t('label.announcement-plural')}</span>
+                      </Space>
+
+                      <span>
+                        {!isUserEntity &&
+                          getCountBadge(
+                            countData.data.conversationCount,
+                            '',
+                            activeTab === ActivityFeedTabs.ANNOUNCEMENTS
+                          )}
+                      </span>
+                    </div>
+                  ),


I guess we have tabLabel component which can be used here

yes, we have tabLabel component , but ig that's for the tabs ,not for the sub tabs. We can use this compo for sub tabs as well, but currently its not supporting icon display, which we require for sub tab.

chirag-madlani · 2024-12-18T17:20:30Z

openmetadata-ui/src/main/resources/ui/src/components/Announcement/announcement.less

+        margin-bottom: 5px;
+        margin-right: 5px;


Can we use our size variable instead hardcoded CSS values?

chirag-madlani · 2024-12-18T17:22:31Z

openmetadata-ui/src/main/resources/ui/src/components/common/PopOverCard/UserPopOverCard.tsx

@@ -264,6 +264,7 @@ const UserPopOverCard: FC<Props> = ({
        <Link
          className={classNames(
            'assignee-item d-flex gap-1 cursor-pointer items-center',
+            'z-9 relative',


Avoid using z-index

chirag-madlani · 2024-12-18T17:23:04Z

openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json

@@ -605,6 +605,7 @@
    "in-lowercase": "in",
    "in-open-metadata": "In OpenMetadata",
    "in-review": "In Review",
+    "inactive": "Inactive",


Please translate and update it with help of AI

chirag-madlani · 2024-12-18T17:23:54Z

openmetadata-ui/src/main/resources/ui/src/pages/ServiceDetailsPage/ServiceDetailsPage.tsx

+      {
+        name: t('label.announcement-plural'),
+        key: EntityTabs.ANNOUNCEMENT,
+        count: 0,


We need to replace it with actual count right?

yes, that will be replaced when the backend changes are available for total announcements count in counts api call. Currently we are not fetching all the announcements (active & inactive both) all at once. Fetching only the selected announcement type ie. active or inactive.

sonarqubecloud · 2024-12-19T15:39:41Z

Quality Gate passed for 'open-metadata-ui'

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.5% Duplication on New Code

See analysis details on SonarQube Cloud

shrushti2000 added 2 commits December 10, 2024 21:22

announcements listing in activity feed and announcement tab in servic…

38ca682

…e page

added localization files

020fd44

shrushti2000 had a problem deploying to test December 10, 2024 16:00 — with GitHub Actions Failure

shrushti2000 changed the title ~~Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page~~ WIP : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page Dec 10, 2024

shrushti2000 added 2 commits December 11, 2024 17:00

fix delete reply and reaction update

d77e1a0

restrict edit and delete actions for non admins

8edcf05

shrushti2000 had a problem deploying to test December 11, 2024 14:26 — with GitHub Actions Failure

shrushti2000 added 3 commits December 12, 2024 12:28

reactions update for announcements

dede9b9

permissions check for announcements

ebe7fd9

feed reactions

7919145

shrushti2000 had a problem deploying to test December 12, 2024 14:14 — with GitHub Actions Failure

css fixes

1a2d323

shrushti2000 had a problem deploying to test December 13, 2024 11:31 — with GitHub Actions Failure

emoji icon issue fix and remove icons

80dd6a3

shrushti2000 had a problem deploying to test December 18, 2024 05:58 — with GitHub Actions Failure

shrushti2000 temporarily deployed to test December 18, 2024 05:58 — with GitHub Actions Inactive

shrushti2000 had a problem deploying to test December 18, 2024 05:58 — with GitHub Actions Failure

fix failing playwright test and minor css fix

323ccdb

shrushti2000 temporarily deployed to test December 18, 2024 10:23 — with GitHub Actions Inactive

shrushti2000 had a problem deploying to test December 18, 2024 10:23 — with GitHub Actions Failure

chirag-madlani reviewed Dec 18, 2024

View reviewed changes

address pr comments

fe71899

shrushti2000 had a problem deploying to test December 19, 2024 10:30 — with GitHub Actions Error

minor fix

fa5d7dc

shrushti2000 had a problem deploying to test December 19, 2024 11:04 — with GitHub Actions Error

translated localization files for inactive keyword

bb1beb4

shrushti2000 had a problem deploying to test December 19, 2024 11:30 — with GitHub Actions Failure

playwright test fix

0f21c91

shrushti2000 temporarily deployed to test December 19, 2024 15:16 — with GitHub Actions Inactive

shrushti2000 had a problem deploying to test December 19, 2024 15:16 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page #18993

Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page #18993

shrushti2000 commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

chirag-madlani Dec 18, 2024

shrushti2000 Dec 19, 2024

sonarqubecloud bot commented Dec 19, 2024

	await updateThreadData(threadId, postId, isThread, data, callback);
	await updateThreadData(threadId, postId, isThread, data, noop);

Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page #18993

Are you sure you want to change the base?

Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page #18993

Conversation

shrushti2000 commented Dec 10, 2024 • edited Loading

Type of change:

Checklist:

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 19, 2024

Quality Gate passed for 'open-metadata-ui'

shrushti2000 commented Dec 10, 2024 •

edited

Loading