Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Filter activity feed events for test cases and test suites. #19004

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix: Filter activity feed events for test cases and test suites. #19004

merged 4 commits into from
Dec 12, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Dec 11, 2024 •
edited by Ashish8689
Loading

Describe your changes:

Fixes

  • Fix the TestCase feed coming in activity feed
  • Fix the flicker around the task button while approving or rejecting the glossary approval task.

Issue :

365613155-be0316b9-6dd8-4e42-b231-5e719257a875.mov

Resolved :

Screen.Recording.2024-12-11.at.5.59.02.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 11, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Dec 11, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner December 11, 2024 08:01
@Siddhanttimeline Siddhanttimeline marked this pull request as draft December 11, 2024 08:01
@Ashish8689 Ashish8689 added the UI UI specific issues label Dec 11, 2024
@Ashish8689 Ashish8689 self-assigned this Dec 11, 2024
@Siddhanttimeline Siddhanttimeline marked this pull request as ready for review December 11, 2024 12:33
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.66% (40323/63342) 40.07% (16045/40044) 42.59% (4805/11282)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pmbrull pmbrull merged commit 81246af into main Dec 12, 2024
33 of 50 checks passed
@pmbrull pmbrull deleted the fix-filter-activity-feed branch December 12, 2024 09:54
Siddhanttimeline added a commit that referenced this pull request Dec 16, 2024
@Siddhanttimeline @Ashish8689
Fix: Filter activity feed events for test cases and test suites. (#19004
cf1c737 
)

* fix: Filter activity feed events for test cases and suites.

* minor fix around the button label after save task tab

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@sonika-shah sonika-shah sonika-shah approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Siddhanttimeline @chirag-madlani @sonika-shah @ShaileshParmar11 @pmbrull @Ashish8689