Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Domain only access policy prevents bots from listing #19017

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Minor: Domain only access policy prevents bots from listing #19017

merged 4 commits into from
Dec 12, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Dec 12, 2024 •
edited by mohityadav766
Loading

Describe your changes:

Fixes listing issue in case Domain Restricted access is enabled

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner December 12, 2024 06:50
@harshach harshach changed the title Minor: Domain only access policy prevents bots listing Minor: Domain only access policy prevents bots from listing Dec 12, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 12, 2024
mohityadav766
mohityadav766 previously approved these changes Dec 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@mohityadav766 mohityadav766 added the e2e This will trigger e2e test workflows label Dec 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mohityadav766 mohityadav766 merged commit e04e2de into main Dec 12, 2024
18 of 33 checks passed
@mohityadav766 mohityadav766 deleted the fix_listing_domain_only_policy branch December 12, 2024 09:49
mohityadav766 pushed a commit that referenced this pull request Dec 12, 2024
@harshach @mohityadav766
Minor: Domain only access policy prevents bots from listing (#19017)
319c681 
* Minor: Domain only access policy prevents bots listing

* Minor: Domain only access policy prevents bots listing

* Add Entity Type condition to limit the scope of NOT IN

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
(cherry picked from commit e04e2de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@mohityadav766 mohityadav766 mohityadav766 left review comments

Assignees
No one assigned
Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshach @pmbrull @mohityadav766