Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reference table dropdown in add and edit query forms #19026

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: reference table dropdown in add and edit query forms #19026

wants to merge 10 commits into from
+25 −11

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Dec 12, 2024 •
edited
Loading

Describe your changes:

  • Removed extra space which was visible when an option was selected from dropdown.

Before
Screenshot 2024-12-12 at 5 29 44 PM

After
Screenshot 2024-12-12 at 4 35 29 PM

  • Added table name with its FQN value to the dropdown of Edit Query functionality.

Before
Screenshot 2024-12-12 at 5 31 42 PM

After
Screenshot 2024-12-12 at 4 36 27 PM

Screenshot 2024-12-12 at 6 18 10 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 marked this pull request as ready for review December 12, 2024 11:11
@Ashish8689 Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Dec 12, 2024
@Ashish8689
Copy link
Contributor

@pranita09 can we add a tooltip around the FQN and name here, If the value exceeds the select box if hard to get the name of the entity.

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.88% (40104/62780) 40.44% (16077/39760) 43.09% (4811/11165)

aniketkatkar97
aniketkatkar97 previously approved these changes Dec 12, 2024
View reviewed changes
@pranita09 pranita09 requested a review from a team as a code owner December 16, 2024 18:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@pranita09 pranita09

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranita09 @Ashish8689 @aniketkatkar97 @ShaileshParmar11