Add Algorithm option for validation in yaml #19049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohityadav766
requested review from
a team,
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
backend
safe to test
Jest test CoverageUI tests summary
|
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
Siddhanttimeline
had a problem deploying
to
test
GitHub Actions
Failure
|
harshach
reviewed
Dec 14, 2024
| @@ -180,6 +180,7 @@ authenticationConfiguration: | |||
| # This will only be valid when provider type specified is customOidc | |||
| providerName: ${CUSTOM_OIDC_AUTHENTICATION_PROVIDER_NAME:-""} | |||
| publicKeyUrls: ${AUTHENTICATION_PUBLIC_KEYS:-[http://localhost:8585/api/v1/system/config/jwks]} | |||
| tokenValidationAlgorithm: ${AUTHENTICATION_TOKEN_VALIDATION_ALGORITHM:-"RS256"} | |||
There was a problem hiding this comment.
we need to update the collate config as well, otherwise those builds will fail when we merge this
There was a problem hiding this comment.
harshach
approved these changes
Dec 14, 2024
mohityadav766
added a commit
that referenced
this pull request
Dec 20, 2024
* Add algorithm option in authentication * ENtity Repository code remove * Keep Default Value * Fix Test --------- Co-authored-by: Siddhant <86899184+Siddhanttimeline@users.noreply.github.com> (cherry picked from commit 50ae01e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>