Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 19073 : Resolve NullPointerException in MS Teams DQ template handling #19062

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Fixes 19073 : Resolve NullPointerException in MS Teams DQ template handling #19062

merged 6 commits into from
Dec 16, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Dec 14, 2024 •
edited
Loading

Describe your changes:

  1. Use buildDQTemplateData from MessageDecorator in MSTeamsMessageDecorator.

Issue:
Reason: Failed to publish event of destination type MsTeams due to Cannot invoke "java.util.Map.getOrDefault(Object, Object)" because "testCaseDetails" is null

Fixes: #19073

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 14, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Dec 14, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner December 14, 2024 18:26
@Siddhanttimeline
fix: Update DQ template logic to handle test case changes and results
76a5013 
Details:
Ensures a general template is created for any changes in the test case.
Generates a DQ template when the test case result is updated.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Siddhanttimeline Siddhanttimeline changed the title fix: Resolve NullPointerException in MS Teams DQ template handling fix #19073 : Resolve NullPointerException in MS Teams DQ template handling Dec 15, 2024
@Siddhanttimeline Siddhanttimeline changed the title fix #19073 : Resolve NullPointerException in MS Teams DQ template handling Fixes #19073 : Resolve NullPointerException in MS Teams DQ template handling Dec 15, 2024
@Siddhanttimeline Siddhanttimeline changed the title Fixes #19073 : Resolve NullPointerException in MS Teams DQ template handling Fixes 19073 : Resolve NullPointerException in MS Teams DQ template handling Dec 15, 2024
@mohityadav766 mohityadav766 merged commit c17e7c8 into main Dec 16, 2024
13 of 19 checks passed
@mohityadav766 mohityadav766 deleted the fix-msteams-dqtemplate-npe branch December 16, 2024 10:37
Siddhanttimeline added a commit that referenced this pull request Dec 16, 2024
@Siddhanttimeline
Fixes 19073 : Resolve NullPointerException in MS Teams DQ template ha…
db2770f 
…ndling (#19062)

* fix: Resolve NullPointerException in MS Teams DQ template handling

* fix: Update DQ template logic to handle test case changes and results

Details:
Ensures a general template is created for any changes in the test case.
Generates a DQ template when the test case result is updated.

* refactor: Make testCaseResult as constant named TEST_CASE_RESULT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException While Sending Data Quality Alert to MS Teams Due to Missing Template Data
3 participants
@Siddhanttimeline @harshach @mohityadav766