Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Create Team to use entityName for create requests #19087

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Dec 16, 2024

Describe your changes:

Fixes

Backed :

  • Change the field data of parent, default role, policies and user from ID to FQN for creating the Team.

UI :

  • Change the field data of parent from ID to FQN for creating the Team.
  • For the deleted team, fix the join team button appearing there.
  • For the deleted team, fix the add user button that is still clickable, even the button is disabled!

Issue :

Screen.Recording.2024-12-16.at.5.49.50.PM.mov

Fixed :

Screen.Recording.2024-12-16.at.5.49.11.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766
Copy link
Contributor Author

@Ashish8689 can you please check the UI side for this, we are still using ids on the request, i think we should change it to fqns like we did for other entities, need it for some other WIP

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.87% (40075/62747) 40.38% (16040/39724) 43.06% (4805/11160)

Copy link

sonarcloud bot commented Dec 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants