-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Create Team to use entityName for create requests #19087
Open
mohityadav766
wants to merge
6
commits into
main
Choose a base branch
from
use-entity-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohityadav766
requested review from
a team,
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
December 16, 2024 08:44
@Ashish8689 can you please check the UI side for this, we are still using ids on the request, i think we should change it to fqns like we did for other entities, need it for some other WIP |
github-actions
bot
added
backend
safe to test
Add this label to run secure Github workflows on PRs
labels
Dec 16, 2024
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
Backed :
parent, default role, policies and user from ID to FQN
for creating the Team.UI :
parent from ID to FQN
for creating the Team.Issue :
Screen.Recording.2024-12-16.at.5.49.50.PM.mov
Fixed :
Screen.Recording.2024-12-16.at.5.49.11.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>