Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): highlight search term for schema table in table details page #19110

Merged
merged 6 commits into from
Dec 18, 2024
Merged

feat(ui): highlight search term for schema table in table details page #19110

merged 6 commits into from
Dec 18, 2024
+95 −4

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Dec 17, 2024 •
edited by chirag-madlani
Loading

Describe your changes:

Fix #19077

Search Term Highlight Feature.
The text typed in search bar is getting highlighted.

Screen.Recording.2024-12-17.at.4.52.32.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 marked this pull request as ready for review December 17, 2024 11:32
@pranita09 pranita09 requested a review from a team as a code owner December 17, 2024 11:32
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.87% (40085/62757) 40.39% (16048/39732) 43.06% (4806/11161)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani changed the title feat: highlight search term feat(ui): highlight search term for schema table in table details page Dec 18, 2024
@chirag-madlani chirag-madlani merged commit 31b1132 into open-metadata:main Dec 18, 2024
15 of 17 checks passed
Ashish8689 pushed a commit that referenced this pull request Dec 19, 2024
@pranita09 @Ashish8689
feat(ui): highlight search term for schema table in table details page (
3add5f9 
#19110)

* feat: highlight search term

* refactor: use stringToHTML instead of parse

* test: highlightSearchText method

* fix: test for schema table

* fix: mock implemetation of stringToHTML

* test: highlightSearchText function with null or falsy parameters

(cherry picked from commit 31b1132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search Term Highlight Feature
2 participants
@pranita09 @chirag-madlani