Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated docs for implicit and auth code flow sso #19126

Conversation

tarunpandey23
Copy link
Contributor

Describe your changes:

Fixes #16124

I worked on updating the documentation related to SSO security. The existing documentation only mentions the implicit flow for SSO, but both the implicit flowand the auth code flow can be used. To provide more clarity on how the auth code flow works, I focused on writing additional documentation for it.

Here is some of the Pictures of the Changes that i made to the documentation.
Screenshot 2024-12-18 at 2 18 26 PM
Screenshot 2024-12-18 at 2 18 51 PM
Screenshot 2024-12-18 at 2 19 15 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@Prajwal214 Prajwal214 added the safe to test Add this label to run secure Github workflows on PRs label Dec 18, 2024
Copy link
Contributor

@Prajwal214 Prajwal214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Prajwal214 Prajwal214 merged commit d578aa7 into open-metadata:main Dec 18, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Deployment] Revisit and update the docs for SSO setup for Implicit Flow and Auth Code Flow
2 participants