Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: Automator requirements oss #19128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Dec 18, 2024

Fixes #1038

  • Fix the ingestion success screen text overflow issue.

Before:
Screenshot 2024-12-18 at 3 21 01 PM

After:
Screenshot 2024-12-18 at 3 21 20 PM

  • Fix the icon alignment issue in the EntityHeader component.

Before:
Screenshot 2024-12-18 at 3 22 01 PM

After:
Screenshot 2024-12-18 at 3 22 08 PM

  • Fix the permissions API calls for the ingestion pipelines to use FQN instead of Name.
  • Introduce the moreActionButtonProps in the PipelineActions component for better customisation.

The following changes are effective for Automator and won't affect the Explore page behaviour

(The tests will be covered in the Automator side)

  • Add the "Database" field in the advanced search for the "Database Schema" asset.
  • Change the field listing behaviour in the advanced search modal, to show the common fields for the multiple assets instead of the union of the fields.
  • Change the search index for the "Name" and "Display Name" field suggestions to use the selected data assets instead of the all "Data Assets" index. (This will help in only showing suggestions for the selected data assets and not all)

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

…ema" asset.

Change the fields listing behavior in the advanced search modal, to show the common fields for the multiple assets instead of union of the fields.
Change the search index for the "Name" and "Display Name" field suggestions to use the selected data assets instead of the all "Data Assets" index.
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.88% (40112/62789) 40.43% (16080/39768) 43.09% (4811/11166)

Copy link

sonarcloud bot commented Dec 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants