Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Encode userName and correct the placeholder for userResetPasswordLink #19139

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: Encode userName and correct the placeholder for userResetPasswordLink #19139

merged 3 commits into from
Dec 19, 2024
+3 −2

Conversation

Siddhanttimeline
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 19, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Dec 19, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner December 19, 2024 09:29
@harshach harshach added Markdown Editor & Previewer Label for markdown support To release Will cherry-pick this PR into the release branch labels Dec 19, 2024
@harshach harshach removed the Markdown Editor & Previewer Label for markdown support label Dec 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@harshach harshach merged commit fb6cbce into main Dec 19, 2024
20 of 35 checks passed
@harshach harshach deleted the bugfix-forgot-password branch December 19, 2024 16:51
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.5.15 branch.
Please cherry-pick the changes manually.
You can find more details here.

harshach pushed a commit that referenced this pull request Dec 19, 2024
@Siddhanttimeline @harshach
fix: Encode userName and correct placeholder for userResetPasswordLink (
a0e7557 
#19139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonika-shah sonika-shah sonika-shah approved these changes

@harshach harshach harshach approved these changes

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siddhanttimeline @harshach @sonika-shah