Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): improve data insight chart and tooltip rendering #19143

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore(ui): improve data insight chart and tooltip rendering #19143

merged 1 commit into from
Dec 19, 2024
+7 −3

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Dec 19, 2024 •
edited
Loading

Describe your changes:

Fixes:
Provision to transform label or not for tooltip
StartCase for TotalEntity Charts

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani chirag-madlani requested a review from a team as a code owner December 19, 2024 11:28
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.88% (40102/62780) 40.42% (16074/39768) 43.08% (4810/11165)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 2b6cdea into main Dec 19, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the di-improvement branch December 19, 2024 13:28
harshach pushed a commit that referenced this pull request Dec 19, 2024
@chirag-madlani @harshach
chore(ui): improve data insight chart and tooltip rendering (#19143)
1179697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirag-madlani @Sachin-chaurasiya @ShaileshParmar11