Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved <NoneType object has no attribute rsplit> issue #19293

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

akashverma0786
Copy link
Contributor

@akashverma0786 akashverma0786 commented Jan 9, 2025

Describe your changes:

Added lineage_source_class and profiler_class inside service_spec of different connectors

Short blurb explaining:

  • What changes did you make?
    • Added lineage source class
  • Why did you make them?
    • We were facing an error :-
    File "/opt/airflow/venv-1.6.1/lib64/python3.9/site-packages/metadata/utils/importer.py", line 130, in import_from_module
        module_name, obj_name = key.rsplit(MODULE_SEPARATOR, 1)
    AttributeError: 'NoneType' object has no attribute 'rsplit'
    
    • This occured because during the lneage execution the code was expecting a lineage_source_class from service_spec and it got None.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
10.5% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@akashverma0786 akashverma0786 marked this pull request as ready for review January 10, 2025 04:39
@akashverma0786 akashverma0786 requested a review from a team as a code owner January 10, 2025 04:39
@ayush-shah ayush-shah merged commit 83894d3 into open-metadata:main Jan 10, 2025
15 of 30 checks passed
@akashverma0786 akashverma0786 deleted the rsplit-issue branch January 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants