Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor(ui): domain owner edit icon and display of announcement message #19593

Merged
merged 1 commit into from
Jan 29, 2025
Merged

minor(ui): domain owner edit icon and display of announcement message #19593

merged 1 commit into from
Jan 29, 2025

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Jan 29, 2025 •
edited
Loading

Describe your changes:

  • Removed edit owner icon when no owner present
    Before
    Screenshot 2025-01-29 at 6 18 07 PM
    After
    Screenshot 2025-01-29 at 6 18 26 PM

  • Fixed the display of announcement message, earlier HTML tags were shown with message
    Before
    Screenshot 2025-01-29 at 6 21 28 PM
    After
    Screenshot 2025-01-29 at 6 03 48 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 29, 2025
@pranita09 pranita09 marked this pull request as ready for review January 29, 2025 12:44
@pranita09 pranita09 requested a review from a team as a code owner January 29, 2025 12:44
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.5% (40989/63552) 40.74% (16421/40310) 43.98% (4976/11314)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ShaileshParmar11
ShaileshParmar11 reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test for the changes

@chirag-madlani chirag-madlani merged commit 060ab6e into open-metadata:main Jan 29, 2025
28 of 37 checks passed
Ashish8689 pushed a commit that referenced this pull request Jan 29, 2025
@pranita09 @Ashish8689
minor: domain owner edit icon and display of announcement message (#1…
6b039ad 
…9593)

(cherry picked from commit 060ab6e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@Ashish8689 Ashish8689 Ashish8689 approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranita09 @chirag-madlani @Ashish8689 @ShaileshParmar11