Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : aggregation issue in opensearch while searching in domain hierarchy #19594

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

sonika-shah
Copy link
Contributor

@sonika-shah sonika-shah commented Jan 29, 2025

Describe your changes:

Fixes the below exception while searching domain hierarachy

Search for the domain in the Entity is failing, with the error
"An exception with message [Cannot invoke \"[os.org](http://os.org/).opensearch.search.aggregations.Aggregations.get(String)\" because the return value of \"[os.org](http://os.org/).opensearch.action.search.SearchResponse.getAggregations()\" is null] was thrown while processing request."

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sonika-shah sonika-shah added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 29, 2025
@sonika-shah sonika-shah requested a review from a team as a code owner January 29, 2025 13:02
@sonika-shah sonika-shah changed the title fix : aggregation issue in opensearch while fetching domain hierarchy fix : aggregation issue in opensearch while searching in domain hierarchy Jan 29, 2025
@mohityadav766 mohityadav766 merged commit 7739822 into main Jan 29, 2025
15 of 19 checks passed
@mohityadav766 mohityadav766 deleted the domain-hierarchy-opensearch-issue branch January 29, 2025 13:44
@sonika-shah
Copy link
Contributor Author

cherry-picked in 1.6.3 !

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants