Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Wrong attribute name in SampleConfig model #19641

Merged
merged 6 commits into from
Feb 4, 2025
Merged

MINOR: Wrong attribute name in SampleConfig model #19641

merged 6 commits into from
Feb 4, 2025

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Feb 3, 2025

Describe your changes:

  • Wrong attribute in profiler sample config

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner February 3, 2025 08:08
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 3, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
E Security Review Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

@TeddyCr TeddyCr merged commit ef131d7 into open-metadata:main Feb 4, 2025
13 of 17 checks passed
TeddyCr added a commit that referenced this pull request Feb 4, 2025
@TeddyCr
MINOR: Wrong attribute name in SampleConfig model (#19641)
679a028 
* fix: wrong attribute name in SampleConfig model

* fix: test attribute

* fix: failing tests

* fix: trino filter error + adjust test to take into account null value

* fix: mssql and azuresql tablesample on views

(cherry picked from commit ef131d7)
TeddyCr added a commit that referenced this pull request Feb 12, 2025
@TeddyCr
MINOR: Wrong attribute name in SampleConfig model (#19641)
93b8fc3 
* fix: wrong attribute name in SampleConfig model

* fix: test attribute

* fix: failing tests

* fix: trino filter error + adjust test to take into account null value

* fix: mssql and azuresql tablesample on views

(cherry picked from commit ef131d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeddyCr @ulixius9