Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Eliminating signup page error #6471

Merged
merged 3 commits into from
Aug 1, 2022
Merged

fix(ui): Eliminating signup page error #6471

merged 3 commits into from
Aug 1, 2022

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Aug 1, 2022

…API call.

Describe your changes :

I worked on the signup page error issue.

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

Screenshot 2022-08-01 at 1 22 46 PM

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Frontend: @open-metadata/ui

@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 07:59 Inactive
@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 07:59 Inactive
@aniketkatkar97 aniketkatkar97 self-assigned this Aug 1, 2022
@cypress
Copy link

cypress bot commented Aug 1, 2022



Test summary

54 1 3 0


Run details

Project openmetadata
Status Failed
Commit a2eb35a
Started Aug 1, 2022 1:26 PM
Ended Aug 1, 2022 1:39 PM
Duration 12:49 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


Failures

cypress/integration/AddNewService/superset.spec.js Failed
1 Superset Ingestion > delete created service

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review August 1, 2022 08:28
@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 11:24 Inactive
@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 11:24 Inactive
@aniketkatkar97 aniketkatkar97 requested review from chirag-madlani and removed request for Sachin-chaurasiya August 1, 2022 11:25
@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Aug 1, 2022
@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 11:43 Inactive
@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 11:43 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 64 Code Smells

76.6% 76.6% Coverage
0.0% 0.0% Duplication

@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 13:09 Inactive
@aniketkatkar97 aniketkatkar97 temporarily deployed to cypress August 1, 2022 13:09 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@harshach
Copy link
Collaborator

harshach commented Aug 1, 2022

@aniketkatkar97 are we showing all the teams listed here or only top 10?

@aniketkatkar97
Copy link
Member Author

aniketkatkar97 commented Aug 1, 2022

@harshach We are showing all the teams we get from API

@harshach harshach merged commit ba24ce9 into main Aug 1, 2022
@harshach harshach deleted the fix-issue-6469 branch August 1, 2022 14:06
@harshach
Copy link
Collaborator

harshach commented Aug 1, 2022

@chirag-madlani @aniketkatkar97 what is the limit param are we passing to search/suggest api?

@aniketkatkar97
Copy link
Member Author

@chirag-madlani @aniketkatkar97 what is the limit param are we passing to search/suggest api?

@harshach , We are passing size 10 for search/query API but no limit params for search/suggest, but we get maximum 5 items in response for search/suggest

@harshach
Copy link
Collaborator

harshach commented Aug 2, 2022

if you pass 10 then you won't list all the teams available right? cc @chirag-madlani

@chirag-madlani
Copy link
Collaborator

@aniketkatkar97 please remove page_size from query api that we use to fetch teams

@chirag-madlani
Copy link
Collaborator

@aniketkatkar97 make sure that we are not limiting anything for frontend while query / search for teams.
Response of the teams depends on how many teams we have so it will be very.

@aniketkatkar97 aniketkatkar97 mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI specific issues
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants