-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Eliminating signup page error #6471
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed! |
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
@aniketkatkar97 are we showing all the teams listed here or only top 10? |
@harshach We are showing all the teams we get from API |
@chirag-madlani @aniketkatkar97 what is the limit param are we passing to search/suggest api? |
@harshach , We are passing size 10 for search/query API but no limit params for search/suggest, but we get maximum 5 items in response for search/suggest |
if you pass 10 then you won't list all the teams available right? cc @chirag-madlani |
@aniketkatkar97 please remove page_size from query api that we use to fetch teams |
@aniketkatkar97 make sure that we are not limiting anything for frontend while query / search for teams. |
…API call.
Describe your changes :
I worked on the signup page error issue.
Type of change :
Frontend Preview (Screenshots) :
Checklist:
Reviewers
Frontend: @open-metadata/ui