Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'supportsDatabase' property in mssqlConnection.json #7015

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

Damon-Zeng
Copy link
Contributor

Describe your changes :

I worked on the issue #7010 because model missing property caused the unexpected running result.

Type of change :

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@Damon-Zeng Damon-Zeng temporarily deployed to cypress August 29, 2022 11:31 Inactive
@Damon-Zeng Damon-Zeng temporarily deployed to cypress August 29, 2022 11:31 Inactive
@github-actions
Copy link
Contributor

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

@cypress
Copy link

cypress bot commented Aug 29, 2022



Test summary

85 3 15 0


Run details

Project openmetadata
Status Failed
Commit 0686b03
Started Aug 29, 2022 11:52 AM
Ended Aug 29, 2022 12:10 PM
Duration 18:23 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


Failures

AddNewService/bigquery.spec.js Failed
1 BigQuery Ingestion > delete created service
Pages/Policies.spec.js Failed
1 Roles page should work properly > Edit policy description
Pages/Roles.spec.js Failed
1 Roles page should work properly > Edit created rule

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Damon-Zeng Damon-Zeng temporarily deployed to cypress August 29, 2022 12:35 Inactive
@Damon-Zeng Damon-Zeng temporarily deployed to cypress August 29, 2022 12:35 Inactive
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harshach harshach requested a review from pmbrull August 30, 2022 15:06
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time! LGTM

@pmbrull pmbrull merged commit 7cd5579 into open-metadata:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants