Fix(UI) #8555: Tags removal issue #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tag removal bug fix - Removed tailwind use and replaced with antd - Code optimisation - Localisation changes
github-actions
bot
added
the
safe to test
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
chirag-madlani
requested changes
Nov 29, 2022
...data-ui/src/main/resources/ui/src/components/DashboardDetails/DashboardDetails.component.tsx
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/MlModelDetail/SourceList.component.tsx
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json
Outdated
Show resolved
Hide resolved
chirag-madlani
approved these changes
Nov 30, 2022
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
|
[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
I worked on the following:
Type of change :
Frontend Preview (Screenshots) :
Table Details Page:
Screen.Recording.2022-11-29.at.7.12.56.PM.mov
Dashboard Details Page:
Screen.Recording.2022-11-29.at.7.13.29.PM.mov
Ml Model Details Page:
Screen.Recording.2022-11-29.at.7.13.58.PM.mov
SourceList component:
Screen.Recording.2022-11-30.at.9.58.09.AM.mov
Checklist:
Reviewers
Frontend: @open-metadata/ui