Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openmetadata workflow issue 9172 #9299

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Openmetadata workflow issue 9172 #9299

merged 7 commits into from
Dec 15, 2022

Conversation

dhruvinmaniar123
Copy link
Contributor

Describe your changes :

I worked on the #issue9172 for creating a new workflow which build the openmetadata application and attach to the existing/new release based on the user inputs or by drafting the new release.

Type of change :

  • New feature

Caveat while running the workflow:

  • If script is being run manually by giving inputs make sure you select tag option instead of branch.
  • Before giving inputs manually make sure that no existing app is attached in the release with same name otherwise the workflow will fail as it won't allow to overwrite the file. In this scenario please go to that release and delete the existing app and then only run the workflow.
  • If you are drafting for new release version make sure to update those versions in workflow under the "release-project-event-release" job.

Reviewers

@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 06:25 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 06:25 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 06:25 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 06:25 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@akash-jain-10 akash-jain-10 self-requested a review December 15, 2022 06:53
@akash-jain-10 akash-jain-10 linked an issue Dec 15, 2022 that may be closed by this pull request
[GITHUB ACTION] Prepare GH Action Job for Docker Publish of openmetadata/server to build the application and update release #9172
Closed
@akash-jain-10 akash-jain-10 added the safe to test Add this label to run secure Github workflows on PRs label Dec 15, 2022
@akash-jain-10 akash-jain-10 temporarily deployed to cypress December 15, 2022 06:54 — with GitHub Actions Inactive
@akash-jain-10 akash-jain-10 temporarily deployed to cypress December 15, 2022 06:54 — with GitHub Actions Inactive
@akash-jain-10 akash-jain-10 temporarily deployed to cypress December 15, 2022 06:54 — with GitHub Actions Inactive
@akash-jain-10 akash-jain-10 temporarily deployed to cypress December 15, 2022 06:54 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:27 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:27 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:27 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:27 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:29 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:29 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:29 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 07:29 — with GitHub Actions Inactive
@cypress
Copy link

cypress bot commented Dec 15, 2022 •
edited
Loading


Test summary

183 • 0 • 3 • 0

Run details
Project openmetadata
Status Passed
Commit 7464ba0
Started Dec 15, 2022 1:17 PM
Ended Dec 15, 2022 1:51 PM
Duration 33:42 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

akash-jain-10
akash-jain-10 requested changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhruvinmaniar123 for the contribution. Left few comments for the code changes. Let's fix those and get this feature available.

.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:12 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:12 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:12 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:12 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:47 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:47 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:47 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 11:47 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 12:52 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 12:52 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 12:52 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to cypress December 15, 2022 12:52 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dhruvinmaniar123
Copy link
Contributor Author

Thanks @akash-jain-10 for the feedback. Changes have been done and resolved.

@sonarqubecloud
Copy link

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

59.2% 59.2% Coverage
0.1% 0.1% Duplication

@akash-jain-10 akash-jain-10 merged commit c511326 into open-metadata:main Dec 15, 2022
aniketkatkar97 pushed a commit that referenced this pull request Dec 15, 2022
@dhruvinmaniar123 @aniketkatkar97
Openmetadata workflow issue 9172 (#9299)
505e3ee 
* adding new file

* adding new workflow of  issue #9172

* adding changes of issue #9172

* adding changes of issue #9172

* adding changes for issue #9172

* adding changes for issue #9172

* adding changes for issue #9172

Co-authored-by: Dhruvin Maniar <dhruvinmaniar@Dhruvins-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

Assignees

@dhruvinmaniar123 dhruvinmaniar123

Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
2 participants
@dhruvinmaniar123 @akash-jain-10