Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Airflow Auth #199

Merged
merged 6 commits into from
Nov 21, 2023
Merged

[Fix] Airflow Auth #199

merged 6 commits into from
Nov 21, 2023

Conversation

dhruvinmaniar123
Copy link
Contributor

@dhruvinmaniar123 dhruvinmaniar123 commented Nov 21, 2023 •
edited
Loading

Fixed the airflow auth condition under pipelineServiceClientConfig. We can now set value of enabled to false if we are not using the default className value.

Type of change :

  • Bug fix
  • [] Improvement
  • [] New feature
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@dhruvinmaniar123 dhruvinmaniar123 self-assigned this Nov 21, 2023
tutte
tutte approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvinmaniar123 dhruvinmaniar123 merged commit 3d830a4 into open-metadata:main Nov 21, 2023
1 check passed
@dhruvinmaniar123 dhruvinmaniar123 deleted the fix-airflowAuth branch November 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@tutte tutte tutte approved these changes

Assignees

@dhruvinmaniar123 dhruvinmaniar123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvinmaniar123 @tutte @akash-jain-10