Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Prepare for 1.2.4 Release #205

Merged
merged 3 commits into from
Jan 5, 2024
Merged

feat: Prepare for 1.2.4 Release #205

merged 3 commits into from
Jan 5, 2024

Conversation

preetsshah
Copy link
Contributor

@preetsshah preetsshah commented Dec 22, 2023 •
edited
Loading

Describe your changes :

The pipelineServiceClientConfig were missing a couple of parameters i.e. truststorePath and truststorePassword as per the new server release v1.2.4 (reference).
Hence updated the required files to include these parameters in helm charts.

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

akash-jain-10
akash-jain-10 requested changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the Camel Casing here! Thanks for the Contribution.

charts/openmetadata/values.yaml Outdated Show resolved Hide resolved
@akash-jain-10 akash-jain-10 changed the title Update pipelineServiceClient configs for v1.2.4 feat: Prepare for 1.2.4 Release Dec 22, 2023
@preetsshah preetsshah mentioned this pull request Dec 22, 2023
Merged
9 tasks
@preetsshah preetsshah marked this pull request as ready for review January 4, 2024 05:33
@akash-jain-10 akash-jain-10 merged commit 0f85170 into open-metadata:main Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preetsshah @akash-jain-10