Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Prepare 1.4.6 Release #251

Merged
merged 3 commits into from
Aug 2, 2024
Merged

feat: Prepare 1.4.6 Release #251

merged 3 commits into from
Aug 2, 2024

Conversation

akash-jain-10
Copy link
Collaborator

What this PR does / why we need it :

Prepare 1.4.6 Release

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@akash-jain-10 akash-jain-10 self-assigned this Jul 29, 2024
Marcus1911
Marcus1911 approved these changes Aug 2, 2024
View reviewed changes
Copy link

@Marcus1911 Marcus1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change version, app and tags to 1.4.6;
FIX OIDC and token ttl.
LGTM

@akash-jain-10 akash-jain-10 merged commit b158bc1 into main Aug 2, 2024
1 check passed
@akash-jain-10 akash-jain-10 deleted the feat/prepare-1-4-6-release branch August 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcus1911 Marcus1911 Marcus1911 approved these changes

@IceS2 IceS2 IceS2 approved these changes

@tutte tutte Awaiting requested review from tutte

@harshach harshach Awaiting requested review from harshach

@TeddyCr TeddyCr Awaiting requested review from TeddyCr

Assignees

@akash-jain-10 akash-jain-10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akash-jain-10 @IceS2 @Marcus1911