Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated skip lint test #283

Merged
merged 1 commit into from
Nov 29, 2024
Merged

updated skip lint test #283

merged 1 commit into from
Nov 29, 2024

Conversation

tarunpandey23
Copy link
Contributor

What this PR does / why we need it :

Fixes #282

Updated ct lint --target-branch=${{ env.default_branch }} to skip version checks over CI.

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • All new and existing tests passed.

Reviewers

@tarunpandey23 tarunpandey23 mentioned this pull request Nov 27, 2024
Closed
3 tasks
akash-jain-10
akash-jain-10 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! LGTM 🚀

@akash-jain-10 akash-jain-10 merged commit 33cef50 into open-metadata:main Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Update lint-test.yml to skip version checking over PRs
2 participants
@tarunpandey23 @akash-jain-10