Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: G2P module fails to initialize #138 #139

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

yuantuo666
Copy link
Collaborator

@yuantuo666 yuantuo666 commented Feb 20, 2024

✨ Description

The G2P module fails to initialize due to using an unassigned variable. This PR fixes this bug.

🚧 Related Issues

#138

πŸ‘¨β€πŸ’» Changes Proposed

  • Fix the bug

πŸ§‘β€πŸ€β€πŸ§‘ Who Can Review?

@lmxue

πŸ›  TODO

None

βœ… Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@yuantuo666 yuantuo666 requested a review from lmxue February 20, 2024 08:28
@yuantuo666
Copy link
Collaborator Author

Before changes

image

After changes

image

@lmxue lmxue merged commit d30b409 into open-mmlab:main Feb 20, 2024
1 check passed
@yuantuo666 yuantuo666 deleted the fix-g2p-init branch February 20, 2024 09:19
ArkhamImp pushed a commit to ArkhamImp/Amphion that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants