Refactor G2P module and related process #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmxue
requested review from
zhizhengwu,
RMSnow,
HeCheng0625 and
VocodexElysium
zhizhengwu
requested changes
Dec 3, 2023
models/tts/base/tts_dataset.py
Outdated
| return packed_batch_features | ||
|
|
||
|
|
||
| #===================== Deprecated Code ============================ |
There was a problem hiding this comment.
If deprecated, can delete them.
models/tts/base/tts_trainer.py
Outdated
| "batch_size": self.cfg.train.batch_size, | ||
| } | ||
| return state_dict | ||
| # def _get_state_dict(self): |
There was a problem hiding this comment.
Not used? If so, delete the commented lines
models/tts/base/tts_trainer.py
Outdated
| ckpt_path = os.path.join(path, "epoch-{:04d}.pt".format(self.epoch)) | ||
| state_dict = self._get_state_dict() | ||
| torch.save(state_dict, ckpt_path) | ||
| # ckpt_path = os.path.join(path, "epoch-{:04d}.pt".format(self.epoch)) |
models/tts/base/tts_trainer.py
Outdated
| ckpt_path = os.path.join(path, "epoch-{:04d}.pt".format(self.epoch)) | ||
| state_dict = self._get_state_dict() | ||
| torch.save(state_dict, ckpt_path) | ||
| # ckpt_path = os.path.join(path, "epoch-{:04d}.pt".format(self.epoch)) |
models/tts/valle/valle_dataset.py
Outdated
| ) | ||
| unique_tokens = SymbolTable.from_file(text_token_path) | ||
| text_tokenizer = TextToken(unique_tokens.symbols, add_bos=True, add_eos=True) | ||
| # ### get text tokenizer |
models/tts/valle/valle_dataset.py
Outdated
| prompt_phone_id_seq, prompt_phn_len = text_tokenizer.get_token_id_seq(utt_info["Prompt_phone"]) | ||
| self.utt2seq[utt] = phone_id_seq | ||
| self.utt2pmtseq[utt] = prompt_phone_id_seq | ||
| # if cfg.preprocess.phone_extractor == 'lexicon': |
There was a problem hiding this comment.
too many commented lines. We need to delete them!
models/tts/vits/vits_trainer.py
Outdated
| def _build_model(self): | ||
|
|
||
| # if self.cfg.preprocess.phone_extractor == 'lexicon': |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code related to g2p, including: