Debug VITS for multi-speaker training #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lmxue
commented
Dec 3, 2023
lmxue
commented
- Update code for multi-speaker VITS training
- Update some other files
lmxue
requested review from
zhizhengwu,
RMSnow,
HeCheng0625 and
VocodexElysium
zhizhengwu
reviewed
Dec 3, 2023
models/tts/valle/valle_trainer.py
Outdated
| "trian_stage": self.args.train_stage | ||
| } | ||
| return state_dict | ||
| # def _get_state_dict(self): |
There was a problem hiding this comment.
Is the commented code implemented in any base trainer (new_trainer or tts_trainer)? If so, we can just delete them.
There was a problem hiding this comment.
It's the testing code before. And unuseful now. I have deleted it.
RMSnow
requested changes
Dec 3, 2023
models/tts/valle/valle_trainer.py
Outdated
| "trian_stage": self.args.train_stage | ||
| } | ||
| return state_dict | ||
| # def _get_state_dict(self): |
There was a problem hiding this comment.
Is the commented code implemented in any base trainer (new_trainer or tts_trainer)? If so, we can just delete them.
RMSnow
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.