Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nms config in demo/faster_rcnn #899

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

wangruohui
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2021

CLA assistant check
All committers have signed the CLA.

@kennymckormick kennymckormick changed the title update nms config in demo/faster_rccn update nms config in demo/faster_rcnn Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #899 (3e5b432) into master (529f454) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   83.62%   83.60%   -0.03%     
==========================================
  Files         132      132              
  Lines        9966     9966              
  Branches     1718     1718              
==========================================
- Hits         8334     8332       -2     
- Misses       1215     1217       +2     
  Partials      417      417              
Flag Coverage Δ
unittests 83.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/augmentations.py 92.98% <0.00%> (-0.46%) ⬇️
mmaction/core/evaluation/accuracy.py 93.18% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529f454...3e5b432. Read the comment docs.

@dreamerlin dreamerlin linked an issue Jun 3, 2021 that may be closed by this pull request
@kennymckormick kennymckormick merged commit 985d284 into open-mmlab:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'ConfigDict' object has no attribute 'nms'
3 participants