Skip to content

Commit

Permalink
[Improve] Skip problematic opencv-python versions (#833)
Browse files Browse the repository at this point in the history
* Update runtime.txt

* Update runtime.txt

* Update runtime.txt

* Update build.yml

* Update runtime.txt

* empty

* empty

* Update runtime.txt

* fix lint
  • Loading branch information
wangruohui authored Jun 10, 2022
1 parent 8b43637 commit 7fe0c57
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
run: pip install torch==${{ matrix.torch }} torchvision==${{ matrix.torchvision }} -f https://download.pytorch.org/whl/torch_stable.html
- name: Install MMCV ${{ matrix.mmcv_link }}
run: |
pip install mmcv-full -f https://download.openmmlab.com/mmcv/dist/${{ matrix.mmcv_link }}/index.html --only-binary mmcv-full "opencv-python<=4.5.4.60"
pip install mmcv-full -f https://download.openmmlab.com/mmcv/dist/${{ matrix.mmcv_link }}/index.html --only-binary mmcv-full
python -c 'import mmcv; print(mmcv.__version__)'
- name: Build and install
run: pip install -e .[all]
Expand Down
5 changes: 2 additions & 3 deletions requirements/runtime.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ facexlib
lmdb
mmcv-full>=1.3.13 # To support DCN on CPU
numpy
opencv-python<=4.5.4.60
opencv-python!=4.5.5.62,!=4.5.5.64
# MMCV depends opencv-python instead of headless, thus we install opencv-python
# Due to a binary compatibility bug, we limit its version before 4.5.5
# Due to a bug from upstream, we skip this two version
# https://github.com/opencv/opencv-python/issues/602
# https://github.com/opencv/opencv/issues/21366
# It seems to be fixed in https://github.com/opencv/opencv/pull/21382
# But our test is negative.
Pillow
tensorboard
torch
Expand Down

0 comments on commit 7fe0c57

Please sign in to comment.