Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe a small bug about RDN #1136

Closed
ryanxingql opened this issue Sep 19, 2022 · 3 comments
Closed

Maybe a small bug about RDN #1136

ryanxingql opened this issue Sep 19, 2022 · 3 comments
Assignees
Labels
kind/bug something isn't working priority/P0 highest priority
Milestone

Comments

@ryanxingql
Copy link
Contributor

ryanxingql commented Sep 19, 2022

Code: https://github.com/open-mmlab/mmediting/blob/e1d488323096c0850a08919ffdb03e0139ca66d7/mmedit/models/backbones/sr_backbones/rdn.py#L54

The output channel number of self.lff is channel_growth.
However, the input channel number of x is in_channels.

In the forward function,
https://github.com/open-mmlab/mmediting/blob/e1d488323096c0850a08919ffdb03e0139ca66d7/mmedit/models/backbones/sr_backbones/rdn.py#L66
the residual learning may lead to error because of the misalignment.

I refer to the original code of RDN. The output channel number should be the same as the input channel number.

@zengyh1900
Copy link
Collaborator

Please check this issue. @plyfager

@zengyh1900 zengyh1900 added in-progress kind/bug something isn't working priority/P0 highest priority and removed in-progress labels Oct 9, 2022
@zengyh1900 zengyh1900 added this to the 0.16.0 milestone Oct 11, 2022
@ryanxingql
Copy link
Contributor Author

I have raised a PR: #1292

@plyfager
Copy link
Collaborator

Thanks for your contribution, #1292 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working priority/P0 highest priority
Projects
None yet
Development

No branches or pull requests

5 participants