Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fixed] Correct the number of output channels of LFF in RDB #1292

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

ryanxingql
Copy link
Contributor

@ryanxingql ryanxingql commented Oct 12, 2022

Motivation

When using the RDB, I found this bug.

The RDB adopts residual learning between x and self.lff(self.layers(x)). However, the channel number of x is in_channels, while the output channels of self.lff is channel_growth.

This bug did not cause error in the past because the default channel_growth of the RDN class is 64, which is not indicated in any config files of RDN. At the same time, all config files use mid_channels=64, which is equal to the channel_growth.

However, when someone uses the RDB class independently, this bug may cause error.

Issue: #1136

Modification

I change the number of output channels of LFF from channel_growth to in_channels.

Who can help? @ them here!

@plyfager

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@ryanxingql ryanxingql changed the title Correct the out_channels of LFF [Bug Fixed] Correct the number of output channels of LFF in RDB Oct 12, 2022
@zengyh1900 zengyh1900 added kind/bug something isn't working awaiting response priority/P0 highest priority labels Oct 13, 2022
@zengyh1900 zengyh1900 added this to the 1.0.0rc2 milestone Oct 13, 2022
@plyfager plyfager self-requested a review October 13, 2022 07:38
@plyfager plyfager merged commit 14f1ffc into open-mmlab:master Oct 13, 2022
@ryanxingql ryanxingql deleted the fix-rdn-bug branch October 13, 2022 07:50
@zengyh1900 zengyh1900 mentioned this pull request Oct 17, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working priority/P0 highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants