[Bug] Correct the number of channels for RDN #1329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanxingql
changed the title
zengyh1900
added
priority/P0
|
@ryanxingql Thanks for your contribution. Currently, the daily development is based on Therefore, please pull dev-1.x and update this PR. |
|
@LeoXing1996 Thank you so much, I close this PR and open another #1332. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The RDN implementation will cause error when
channel_growth != mid_channels.Modification
We have fixed the bug of RDN in V0.15 (PRs #1292 and #1311). Also, PR #1326 updates the docstring for RDN. Now we adopt these changes into V1.x.
We also add the
channel_growthoption into the cfg of the RDN test file.Great thanks to @plyfager, @LeoXing1996 and @zengyh1900 who have reviewed these PRs.