-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeCamp #99] type hints Part B #1481
Conversation
spearable_conv_module.py参数kernel_size,stride,padding,dilation根据ConvModule的同名参数进行修改类型。resnet.py类ResNet中forward函数返回的类型是list;其他部分根据要求修改
根据tests/test_models/test_base_archs/test_img_normalize.py创建这个class时给的参数rgb_mean和rgb_std的类型,以及mmedit/models/editors/ttsr/lte.py创建这个class的参数vgg_mean和vgg_std的参数类型,修改img_mean 和 img_std的类型
Codecov ReportBase: 88.04% // Head: 88.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1481 +/- ##
===========================================
+ Coverage 88.04% 88.05% +0.01%
===========================================
Files 383 383
Lines 24176 24210 +34
Branches 3793 3793
===========================================
+ Hits 21285 21319 +34
Misses 2076 2076
Partials 815 815
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
base_edit_model.py函数convert_to_datasample的返回类型修改为List[EditDataSample],因为其返回的变量inputs也是函数的参数,因此将参数inputs的类型也修改为List[EditDataSample]; base_mattor.py的函数convert_to_datasample的返回类型修改为List[EditDataSample]
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: