Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp #99] type hints Part B #1481

Merged
merged 26 commits into from
Dec 14, 2022
Merged

[CodeCamp #99] type hints Part B #1481

merged 26 commits into from
Dec 14, 2022

Conversation

xiaomile
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zengyh1900 zengyh1900 changed the title type hints Part B [CodeCamp #99] type hints Part B Nov 29, 2022
mmedit/models/base_archs/ensemble.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/ensemble.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/gated_conv_module.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/img_normalize.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/linear_module.py Outdated Show resolved Hide resolved
mmedit/models/base_models/two_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_models/two_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_models/two_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_models/two_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_models/one_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/linear_module.py Show resolved Hide resolved
mmedit/models/base_archs/resnet.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/resnet.py Outdated Show resolved Hide resolved
mmedit/models/base_archs/separable_conv_module.py Outdated Show resolved Hide resolved
mmedit/models/base_models/one_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_models/two_stage.py Show resolved Hide resolved
mmedit/models/base_models/two_stage.py Outdated Show resolved Hide resolved
mmedit/models/base_models/one_stage.py Show resolved Hide resolved
mmedit/models/base_models/one_stage.py Show resolved Hide resolved
mmedit/models/base_models/one_stage.py Outdated Show resolved Hide resolved
spearable_conv_module.py参数kernel_size,stride,padding,dilation根据ConvModule的同名参数进行修改类型。resnet.py类ResNet中forward函数返回的类型是list;其他部分根据要求修改
根据tests/test_models/test_base_archs/test_img_normalize.py创建这个class时给的参数rgb_mean和rgb_std的类型,以及mmedit/models/editors/ttsr/lte.py创建这个class的参数vgg_mean和vgg_std的参数类型,修改img_mean 和 img_std的类型
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 88.04% // Head: 88.05% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (cf68049) compared to base (b1ca2b5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head cf68049 differs from pull request most recent head 650ec60. Consider uploading reports for the commit 650ec60 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1481      +/-   ##
===========================================
+ Coverage    88.04%   88.05%   +0.01%     
===========================================
  Files          383      383              
  Lines        24176    24210      +34     
  Branches      3793     3793              
===========================================
+ Hits         21285    21319      +34     
  Misses        2076     2076              
  Partials       815      815              
Flag Coverage Δ
unittests 88.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/base_archs/aspp.py 100.00% <100.00%> (ø)
mmedit/models/base_archs/downsample.py 100.00% <100.00%> (ø)
mmedit/models/base_archs/ensemble.py 97.72% <100.00%> (+0.05%) ⬆️
mmedit/models/base_archs/gated_conv_module.py 100.00% <100.00%> (ø)
mmedit/models/base_archs/img_normalize.py 100.00% <100.00%> (ø)
mmedit/models/base_archs/linear_module.py 100.00% <100.00%> (ø)
mmedit/models/base_archs/multi_layer_disc.py 94.73% <100.00%> (+0.19%) ⬆️
mmedit/models/base_archs/patch_disc.py 87.50% <100.00%> (+0.65%) ⬆️
mmedit/models/base_archs/resnet.py 88.37% <100.00%> (+0.44%) ⬆️
mmedit/models/base_archs/separable_conv_module.py 100.00% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

base_edit_model.py函数convert_to_datasample的返回类型修改为List[EditDataSample],因为其返回的变量inputs也是函数的参数,因此将参数inputs的类型也修改为List[EditDataSample];
base_mattor.py的函数convert_to_datasample的返回类型修改为List[EditDataSample]
@LeoXing1996 LeoXing1996 merged commit 8137c28 into open-mmlab:dev-1.x Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants