Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] update changelog #1567

Merged
merged 7 commits into from
Jan 3, 2023
Merged

[release] update changelog #1567

merged 7 commits into from
Jan 3, 2023

Conversation

liuwenran
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2022

CLA assistant check
All committers have signed the CLA.

@liuwenran liuwenran changed the base branch from 1.x to dev-1.x December 30, 2022 12:01
@liuwenran liuwenran changed the title bump to v1.0.0rc5 update changelog Dec 30, 2022
@liuwenran liuwenran changed the title update changelog [release] update changelog Dec 30, 2022
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 88.87% // Head: 88.87% // No change to project coverage 👍

Coverage data is based on head (b49aa1b) compared to base (c31276d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1567   +/-   ##
========================================
  Coverage    88.87%   88.87%           
========================================
  Files          399      399           
  Lines        26015    26015           
  Branches      4044     4044           
========================================
  Hits         23121    23121           
  Misses        1991     1991           
  Partials       903      903           
Flag Coverage Δ
unittests 88.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/version.py 91.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/en/changelog.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@liuwenran liuwenran merged commit 58f0334 into dev-1.x Jan 3, 2023
@liuwenran liuwenran deleted the v1.0.0rc5 branch January 3, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants