-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Make forward logic more clear for GAN models #1670
[Enhancement] Make forward logic more clear for GAN models #1670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any operations for packing and unpacking datasamples
should be apart from the implementation of the algorithm.
1e947f3
to
ba85fbd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## refactor-metric-loop-and-preprocessor #1670 +/- ##
========================================================================
Coverage ? 87.80%
========================================================================
Files ? 399
Lines ? 26368
Branches ? 4114
========================================================================
Hits ? 23152
Misses ? 2329
Partials ? 887
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we leave the loop for EditDataSample insideSinGAN
in future PR.
* make forward logic more clear for GAN models * revise eg3d inferencer unit test * polish length calculate and split operation for EditDataSample * revise forward pipeline for BaseGAN and BaseCondGAN * revise forward pipeline for EG3D * revise forward pipeline for PGGAN * remove useless comments from SinGAN * remove is_stacked property from EditDataSample
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The
forward
function for GAN models is unclear. Therefore we modify them in this PR.Modification
Revise the forward logic for GAN models.
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: