Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix gui VideoSlider bug #1885

Merged
merged 1 commit into from
May 31, 2023
Merged

[Fix] fix gui VideoSlider bug #1885

merged 1 commit into from
May 31, 2023

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented May 31, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran self-assigned this May 31, 2023
@Z-Fran Z-Fran linked an issue May 31, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3c5bd83) 83.00% compared to head (fe8f6f5) 83.00%.

❗ Current head fe8f6f5 differs from pull request most recent head f77b146. Consider uploading reports for the commit f77b146 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1885   +/-   ##
=======================================
  Coverage   83.00%   83.00%           
=======================================
  Files         411      411           
  Lines       27607    27607           
  Branches     4317     4317           
=======================================
  Hits        22915    22915           
  Misses       3756     3756           
  Partials      936      936           
Flag Coverage Δ
unittests 83.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran merged commit 87622b9 into open-mmlab:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] component.py file in the GUI, it should be self.v2 instead of self.v1
1 participant