Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support Prompt-to-prompt, ddim inversion and null-text inversion #1908

Merged
merged 21 commits into from
Jul 12, 2023

Conversation

FerryHuang
Copy link
Contributor

Support Prompt-to-prompt, ddim inversion and null-text inversion.

Considering that these three methods share common features and can be combined, I implemented them as modules in this project.

Checklist

Before PR:

  • [√] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [√] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [√] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [√] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [√] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran requested a review from LeoXing1996 June 19, 2023 03:04
@LeoXing1996
Copy link
Collaborator

@FerryHuang Sorry for late response. The implementation is already good enough. However, there is one aspect that needs improvement: directly uploading images will increase the repository's size. Please change the images in the markdown to image hosting links.

For example, you can drag and drop an image into the chat box in Github and a link will be generated. This link will be permanently saved in Github and you can use it in your markdown.

@FerryHuang
Copy link
Contributor Author

@FerryHuang Sorry for late response. The implementation is already good enough. However, there is one aspect that needs improvement: directly uploading images will increase the repository's size. Please change the images in the markdown to image hosting links.

For example, you can drag and drop an image into the chat box in Github and a link will be generated. This link will be permanently saved in Github and you can use it in your markdown.

Thanks for the trick! And changes have been made~

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@LeoXing1996 LeoXing1996 merged commit d650945 into open-mmlab:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants