Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix a bug in mmagic/models/editors/stylegan2/stylegan2_generator.py #1956

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

qsun1
Copy link
Contributor

@qsun1 qsun1 commented Jul 25, 2023

Motivation

misuage of torch.flip

Modification

torch.flip(input, dims)
dims is of list / tuple type, instead of a int;

We change 1 $\rightarrow$ [1].

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2023

CLA assistant check
All committers have signed the CLA.

@LeoXing1996
Copy link
Collaborator

@qsun1 Thanks for your contribution. Please sign CLA, then this PR can be merged!

@OpenMMLab-Assistant-004

Hi @qsun1,

We'd like to express our appreciation for your valuable contributions to the mmagic. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01417a1) 82.31% compared to head (110fcfe) 82.31%.
Report is 2 commits behind head on main.

❗ Current head 110fcfe differs from pull request most recent head e85f156. Consider uploading reports for the commit e85f156 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         416      416           
  Lines       27966    27966           
  Branches     4375     4375           
=======================================
  Hits        23020    23020           
  Misses       3997     3997           
  Partials      949      949           
Flag Coverage Δ
unittests 82.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ic/models/editors/stylegan2/stylegan2_generator.py 91.71% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoXing1996 LeoXing1996 merged commit 05fa17e into open-mmlab:main Jul 27, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants