Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-647] Add new configs of EG3D #1985

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

RangeKing
Copy link
Contributor

@RangeKing RangeKing commented Aug 19, 2023

Motivation

Add new configs of EG3D

The output of config_validate.py:
config_validate_3

The output of demo.py:
config_validate_2

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f9befbb) 80.73% compared to head (f0678c2) 80.73%.
Report is 1 commits behind head on main.

❗ Current head f0678c2 differs from pull request most recent head b70907e. Consider uploading reports for the commit b70907e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files         424      424           
  Lines       29109    29109           
  Branches     4502     4502           
=======================================
  Hits        23502    23502           
  Misses       4630     4630           
  Partials      977      977           
Flag Coverage Δ
unittests 80.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoXing1996 LeoXing1996 self-assigned this Aug 23, 2023
@LeoXing1996 LeoXing1996 merged commit 7525478 into open-mmlab:main Aug 23, 2023
@RangeKing RangeKing deleted the new_config_EG3D branch August 24, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants