Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-648]MMagic 新 config 体验与适配 GuidedDiffusion #2005

Merged

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Aug 28, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

add new config for mmagic/guided_diffusion
output of the config_validate.py is True
屏幕截图 2023-08-29 190418

output of Infer Instructions
屏幕截图 2023-08-23 164531
the output inTest Instructions python tools/test.py mmagic/configs/guided_diffusion/adm_ddim250_8xb32_imagenet_64x64.py https://download.openmmlab.com/mmgen/guided_diffusion/adm-u-cvt-rgb_8xb32_imagenet-64x64-7ff0080b.pth
屏幕截图 2023-08-29 190537
it's show thelabel in sample_kwargs is none(in adm.py), so i # it,actually ,the config isn't have label and ouput is success!
屏幕截图 2023-08-29 191107

屏幕截图 2023-08-29 191243

Modification

add mmagic/configs/

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (062bc21) 80.73% compared to head (981d013) 80.73%.
Report is 1 commits behind head on main.

❗ Current head 981d013 differs from pull request most recent head a31bfee. Consider uploading reports for the commit a31bfee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files         424      424           
  Lines       29109    29109           
  Branches     4502     4502           
=======================================
  Hits        23502    23502           
  Misses       4630     4630           
  Partials      977      977           
Flag Coverage Δ
unittests 80.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ooooo-create
Copy link
Contributor Author

@LeoXing1996 may be it can be reviewed,I just updated it😍

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I only have one small modification requests.
Since PR #2007 is merged, you can remove those comments to skip flake8 checking.

@ooooo-create
Copy link
Contributor Author

Nice work, I only have one small modification requests. Since PR #2007 is merged, you can remove those comments to skip flake8 checking.

done

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoXing1996 LeoXing1996 merged commit db3a630 into open-mmlab:main Aug 29, 2023
@ooooo-create ooooo-create deleted the fgy/newconfigs_guided_diffusion branch August 30, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants