Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-649] MMagic 新 config 体验与适配 Instance Colorization #2010

Merged

Conversation

ooooo-create
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

add mmagic/configs/_base_/default_runtime.py
add mmagic/configs/inst_colorization/inst-colorizatioon_full_official_cocostuff-256x256.py

  • output of python ./tools/config_validate.py --new mmagic/configs/inst_colorization/inst-colorizatioon_full_official_cocostuff-256x256.py --old configs/inst_colorization/inst-colorizatioon_full_official_cocostuff-256x256.py --scope mmagic
    屏幕截图 2023-08-30 174938
  • output of python demo/mmagic_inference_demo.py --model-name inst_colorization --model-config mmagic/configs/inst_colorization/inst-colorizatioon_full_official_cocostuff-256x256.py --img input.jpg --result-out-dir demo_colorization_res.png
    屏幕截图 2023-08-30 165611
  • input image
    input
  • output image
    demo_colorization_res
  • A question:the command in configs/inst_colorization/README.md is wrong, may i update it in this pr?
    屏幕截图 2023-08-30 175413

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head c1adea1 differs from pull request most recent head 1b6ffd0. Consider uploading reports for the commit 1b6ffd0 to get more accurate results

📢 Thoughts on this report? Let us know!.

@liuwenran
Copy link
Collaborator

Thanks for your contribution!
And you mentioned that "the command in configs/inst_colorization/README.md is wrong, may i update it in this pr?" , please update this , thank you very much !

@ooooo-create
Copy link
Contributor Author

Thanks for your contribution! And you mentioned that "the command in configs/inst_colorization/README.md is wrong, may i update it in this pr?" , please update this , thank you very much !

done

Copy link
Collaborator

@liuwenran liuwenran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM

@liuwenran liuwenran merged commit 2d48b2c into open-mmlab:main Sep 1, 2023
@ooooo-create ooooo-create deleted the new_configs_inst_colorization branch September 23, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants