Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-240]Adding support for Consistency Models #2086

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

xiaomile
Copy link
Contributor

clean the old commit message,open a new pr for #2045

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

clean the old commit message,open a new pr for open-mmlab#2045
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 77.19088% with 190 lines in your changes are missing coverage. Please review.

Project coverage is 78.38%. Comparing base (ef68f11) to head (2659b89).
Report is 17 commits behind head on main.

❗ Current head 2659b89 differs from pull request most recent head b9c5000. Consider uploading reports for the commit b9c5000 to get more accurate results

Files Patch % Lines
...itors/consistency_models/consistencymodel_utils.py 74.86% 60 Missing and 30 partials ⚠️
...ors/consistency_models/consistencymodel_modules.py 79.62% 53 Missing and 13 partials ⚠️
...els/editors/consistency_models/consistencymodel.py 76.87% 16 Missing and 18 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
+ Coverage   75.70%   78.38%   +2.68%     
==========================================
  Files         441      445       +4     
  Lines       32295    33189     +894     
  Branches     5082     5210     +128     
==========================================
+ Hits        24449    26016    +1567     
+ Misses       6775     5888     -887     
- Partials     1071     1285     +214     
Flag Coverage Δ
unittests 78.38% <77.19%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant