Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onnx conversion of maxunpool2d #243

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

grimoire
Copy link
Member

@grimoire grimoire commented Apr 8, 2021

Hi
This PR fix ONNX conversion of maxunpool2d by adding offset to indices.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #243 (1e5ad4c) into master (2827d93) will decrease coverage by 0.64%.
The diff coverage is 58.44%.

❗ Current head 1e5ad4c differs from pull request most recent head 5f4f2ec. Consider uploading reports for the commit 5f4f2ec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   81.79%   81.14%   -0.65%     
==========================================
  Files         152      153       +1     
  Lines        7223     7436     +213     
  Branches     1066     1088      +22     
==========================================
+ Hits         5908     6034     +126     
- Misses       1191     1271      +80     
- Partials      124      131       +7     
Flag Coverage Δ
unittests 81.14% <58.44%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckbones/encoder_decoders/decoders/plain_decoder.py 66.29% <0.00%> (-24.62%) ⬇️
mmedit/models/restorers/liif.py 65.07% <65.07%> (ø)
mmedit/datasets/pipelines/utils.py 94.64% <100.00%> (+5.35%) ⬆️
mmedit/models/restorers/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2827d93...5f4f2ec. Read the comment docs.

warnings.warn(
'The definitions of indices are different between Pytorch and ONNX'
', so the outputs between Pytorch and ONNX maybe different')
# get shape
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may add the reasons why we do this change with comments here.

@innerlee innerlee merged commit 3c26d34 into open-mmlab:master Apr 10, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants