Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] math notation in docstring #741

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

wangruohui
Copy link
Member

Standalone * in docstring is not correctly rendered. Previous \* not either. Try :math: notation following PyTorch.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #741 (31394c6) into master (efa1818) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 31394c6 differs from pull request most recent head 2dc6698. Consider uploading reports for the commit 2dc6698 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
- Coverage   83.03%   82.95%   -0.09%     
==========================================
  Files         216      215       -1     
  Lines       12192    12121      -71     
  Branches     1964     1945      -19     
==========================================
- Hits        10124    10055      -69     
+ Misses       1764     1762       -2     
  Partials      304      304              
Flag Coverage Δ
unittests 82.93% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/common/linear_module.py 100.00% <ø> (ø)
mmedit/utils/setup_env.py 95.45% <0.00%> (-4.55%) ⬇️
mmedit/models/restorers/basicvsr.py 68.88% <0.00%> (-2.83%) ⬇️
mmedit/apis/restoration_video_inference.py 17.85% <0.00%> (-2.49%) ⬇️
mmedit/datasets/builder.py 93.10% <0.00%> (-1.73%) ⬇️
mmedit/datasets/sr_folder_video_dataset.py 98.55% <0.00%> (-0.07%) ⬇️
mmedit/datasets/pipelines/augmentation.py 98.49% <0.00%> (-0.01%) ⬇️
mmedit/models/common/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/sr_reds_dataset.py 100.00% <0.00%> (ø)
mmedit/datasets/sr_vid4_dataset.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f440728...2dc6698. Read the comment docs.

@wangruohui wangruohui requested a review from Yshuo-Li February 18, 2022 06:03
@wangruohui wangruohui merged commit 5ea708b into open-mmlab:master Feb 24, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants