Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Skip problematic opencv-python versions #833

Merged
merged 9 commits into from
Jun 10, 2022
Merged

[Improve] Skip problematic opencv-python versions #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c835476
Update runtime.txt
wangruohui Apr 6, 2022
55a2766
Update runtime.txt
wangruohui Apr 6, 2022
6e94248
Update runtime.txt
wangruohui Apr 6, 2022
f243dc6
Update build.yml
wangruohui Apr 6, 2022
2e69958
Update runtime.txt
wangruohui Apr 8, 2022
865d6bd
empty
wangruohui Jun 9, 2022
a6a37ae
empty
wangruohui Jun 9, 2022
f33a269
Update runtime.txt
wangruohui Jun 9, 2022
f8ebbf7
fix lint
wangruohui Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
run: pip install torch==${{ matrix.torch }} torchvision==${{ matrix.torchvision }} -f https://download.pytorch.org/whl/torch_stable.html
- name: Install MMCV ${{ matrix.mmcv_link }}
run: |
pip install mmcv-full -f https://download.openmmlab.com/mmcv/dist/${{ matrix.mmcv_link }}/index.html --only-binary mmcv-full "opencv-python<=4.5.4.60"
pip install mmcv-full -f https://download.openmmlab.com/mmcv/dist/${{ matrix.mmcv_link }}/index.html --only-binary mmcv-full
python -c 'import mmcv; print(mmcv.__version__)'
- name: Build and install
run: pip install -e .[all]
Expand Down
5 changes: 2 additions & 3 deletions requirements/runtime.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
lmdb
mmcv-full>=1.3.13 # To support DCN on CPU
numpy
opencv-python<=4.5.4.60
opencv-python!=4.5.5.62,!=4.5.5.64
# MMCV depends opencv-python instead of headless, thus we install opencv-python
# Due to a binary compatibility bug, we limit its version before 4.5.5
# Due to a bug from upstream, we skip this two version
# https://github.com/opencv/opencv-python/issues/602
# https://github.com/opencv/opencv/issues/21366
# It seems to be fixed in https://github.com/opencv/opencv/pull/21382
# But our test is negative.
Pillow
tensorboard
torch>=1.5.0
Expand Down