Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add cummax/cummin tensorrt plugin #1031

Merged
merged 5 commits into from
May 24, 2021

Conversation

grimoire
Copy link
Member

Hi,
This PR adds cummax/cummin support to TensorRT.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #1031 (824d29d) into master (b8c09f3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   65.30%   65.29%   -0.01%     
==========================================
  Files         154      154              
  Lines        9891     9899       +8     
  Branches     1801     1803       +2     
==========================================
+ Hits         6459     6464       +5     
- Misses       3099     3104       +5     
+ Partials      333      331       -2     
Flag Coverage Δ
unittests 65.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/tensorrt/tensorrt_utils.py 1.86% <0.00%> (-0.05%) ⬇️
mmcv/runner/hooks/logger/tensorboard.py 34.37% <0.00%> (-1.11%) ⬇️
mmcv/runner/hooks/logger/pavi.py 71.01% <0.00%> (+0.42%) ⬆️
mmcv/runner/hooks/logger/mlflow.py 81.25% <0.00%> (+0.60%) ⬆️
mmcv/runner/hooks/logger/wandb.py 69.69% <0.00%> (+0.94%) ⬆️
mmcv/runner/hooks/logger/base.py 70.87% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c09f3...824d29d. Read the comment docs.

@RunningLeon RunningLeon requested a review from ZwwWayne May 21, 2021 08:05
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 9d1436f into open-mmlab:master May 24, 2021
@grimoire grimoire deleted the trt_cummmaxmin branch September 15, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants