Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update readme and docs #1190

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Conversation

zhouzaida
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #1190 (631fb04) into master (96c4b70) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   67.97%   68.00%   +0.02%     
==========================================
  Files         159      160       +1     
  Lines       10434    10442       +8     
  Branches     1899     1902       +3     
==========================================
+ Hits         7093     7101       +8     
+ Misses       2970     2968       -2     
- Partials      371      373       +2     
Flag Coverage Δ
unittests 68.00% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/trace.py 54.54% <0.00%> (ø)
mmcv/utils/__init__.py 88.88% <0.00%> (+0.65%) ⬆️
mmcv/ops/cc_attention.py 38.70% <0.00%> (+1.00%) ⬆️
mmcv/runner/iter_based_runner.py 60.00% <0.00%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c4b70...631fb04. Read the comment docs.

@ZwwWayne ZwwWayne mentioned this pull request Jul 12, 2021
Copy link
Collaborator

@ZwwWayne ZwwWayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ZwwWayne
Copy link
Collaborator

need to fix some tweaks

@zhouzaida
Copy link
Collaborator Author

need to fix some tweaks

done

@zhouzaida zhouzaida mentioned this pull request Jul 15, 2021
12 tasks
@ZwwWayne ZwwWayne merged commit 3040299 into open-mmlab:master Jul 20, 2021
@zhouzaida zhouzaida deleted the update-readme branch November 4, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants