Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Restrict the warning message #1267

Merged
merged 22 commits into from
Sep 7, 2021
Merged

[Fix] Restrict the warning message #1267

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
869d3f9
restrict the warning message
yyz561 Aug 13, 2021
013f784
and an important keyword in warning description
yyz561 Aug 13, 2021
7586e6b
a more elegant way of condition
yyz561 Aug 13, 2021
aa86372
link format code too long
yyz561 Aug 14, 2021
d496a56
Merge branch 'open-mmlab:master' into master
yyz561 Aug 16, 2021
ad41357
fix the stupid spelling mistake
yyz561 Aug 16, 2021
d4dec7d
Use issubclass to restrict warning message.
yyz561 Aug 16, 2021
225e5f9
maybe this version is more elegant.
yyz561 Aug 16, 2021
9e6f414
conv + bias + norm warning pytest
yyz561 Aug 16, 2021
ea58eeb
'created' a warning, hahaha
yyz561 Aug 16, 2021
06bae8c
isort and yapf format revision
yyz561 Aug 16, 2021
9916548
isort and yapf format revision
yyz561 Aug 16, 2021
c4bc365
flake8 fail issue
yyz561 Aug 16, 2021
7217059
I have to right this way in order to solve the conflicts between yapf…
yyz561 Aug 17, 2021
6f75ee1
fixed test bug
yyz561 Aug 17, 2021
448957d
Add ruby windows installer source.
yyz561 Aug 18, 2021
eb2b75e
Simplified the code and remove ruby source from CONTRIBUTING.md
yyz561 Aug 19, 2021
f296ada
use _BatchNorm to simplify the code
yyz561 Aug 21, 2021
306dc0f
Merge branch 'master' of https://github.com/open-mmlab/mmcv
yyz561 Aug 24, 2021
2078fb0
bug fix and add instanceNorm case into warning
yyz561 Aug 25, 2021
1a05fee
change the warning message to make it more clear
yyz561 Aug 27, 2021
817ea57
fix unit test
yyz561 Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mmcv/cnn/bricks/conv_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ def __init__(self,
self.with_bias = bias

if self.with_norm and self.with_bias:
warnings.warn('ConvModule has norm and bias at the same time')
if self.conv_cfg.get('type') in ['BN', 'BN1d', 'BN2d', 'BN3d']:
warnings.warn('ConvModule has norm and bias at the same time')

if self.with_explicit_padding:
pad_cfg = dict(type=padding_mode)
Expand Down