Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove some outdated lines #1370

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Sep 24, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Due to our lowest supported PyTorch is 1.3.0, I remove the condition to check whether PyTorch version is lower than 1.0 in get_dist_info()

Modification

modify get_dist_info()

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida changed the title [Refactor] Remove outdated code [Refactor] Remove some outdated lines Sep 24, 2021
@zhouzaida zhouzaida requested a review from ZwwWayne September 24, 2021 14:44
@Junjun2016
Copy link
Contributor

Please fix the CI error!

@zhouzaida zhouzaida mentioned this pull request Sep 26, 2021
29 tasks
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #1370 (d50ea24) into master (a90b397) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
+ Coverage   68.57%   68.59%   +0.01%     
==========================================
  Files         164      164              
  Lines       10897    10891       -6     
  Branches     1993     1991       -2     
==========================================
- Hits         7473     7471       -2     
+ Misses       3032     3030       -2     
+ Partials      392      390       -2     
Flag Coverage Δ
unittests 68.59% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/dist_utils.py 51.06% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90b397...d50ea24. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 8cac7c2 into open-mmlab:master Sep 26, 2021
@zhouzaida zhouzaida deleted the remove-outdated-code branch September 26, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants